Add a helper for nonconflicting, multihost-safe filenames #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
code | style
happz
requested review from
psss,
lukaszachy,
thrix and
janhavlin
as code owners
happz
force-pushed
the
safe-multihost-name-helper
branch
3 times, most recently
from
6c3e6f1
to
585e588
Compare
therazix
approved these changes
Nov 8, 2023
lukaszachy
approved these changes
Nov 8, 2023
happz
force-pushed
the
safe-multihost-name-helper
branch
from
585e588
to
d553a7a
Compare
happz
force-pushed
the
safe-multihost-name-helper
branch
from
d553a7a
to
01c5631
Compare
Not really, no. Rebased, fixed the conflict, and we're good to go. I believe we will cover this once we start moving tmt-generated files - test wrapper, AVC logs, guest logs, etc. - into a directory as we discussed recently, that will offer plenty of opportunities to verify all files are named correctly. |
Since we entered the realms of multihost and parallel executions of phases, we need filenames that, when used by a phase on multiple guests or by one plugin executed multiple times, would allow for now race conditions. We cannot afford a phase overwriting a script wrapper or guest topology. There are already two places where such files are constructed, two more are in pending pull requests, one is clearly missing, and more will be needed when we start exposing guest facts to guest-setup playbooks. Or to `prepare/feature` plugin. So, to avoid confusion about how such a file should be called, there's a helper function. If we ever get Pyright, together with a `NewType` we might be able to prevent using non-unique filenames where safe ones are needed. Patch requires a bit of refactoring of guest topology saving, but nothing serious.
psss
force-pushed
the
safe-multihost-name-helper
branch
from
01c5631
to
8d7c415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we entered the realms of multihost and parallel executions of phases, we need filenames that, when used by a phase on multiple guests or by one plugin executed multiple times, would allow for now race conditions. We cannot afford a phase overwriting a script wrapper or guest topology.
There are already two places where such files are constructed, two more are in pending pull requests, one is clearly missing, and more will be needed when we start exposing guest facts to guest-setup playbooks. Or to
prepare/featureplugin.So, to avoid confusion about how such a file should be called, there's a helper function. If we ever get Pyright, together with a
NewTypewe might be able to prevent using non-unique filenames where safe ones are needed.Patch requires a bit of refactoring of guest topology saving, but nothing serious.
Pull Request Checklist